Preparing the ES Embeddings Rewriter #1
Conversation
mkr
commented
Mar 22, 2023
mkr
commented
- Fixing parsing embeddings containing numbers without decimals (mostly for tests)
- Using the Lucene query for boosting directly to avoid re-parsing in ES
…e-parse the embedding query String in Elasticsearch.
renekrie
left a comment
renekrie
left a comment
There was a problem hiding this comment.
Please see comment inline
| } | ||
| } | ||
|
|
||
| public Embedding parseEmbeddingFromResponse(InputStream is) { |
There was a problem hiding this comment.
I'm not understanding why this has been changed. What is the benefit of not using JsonUtil.readJson()?
There was a problem hiding this comment.
The code before was
(List<Double>) JsonUtil.readJson(con.getInputStream(), Map.class).get("embedding")
What happens here is that the Jackson Objectmapper will just read the object as a map and the embedding field as a List. It does not try to coerce into a common List element type, i.e. you get a List of (Double, Integer, Double) if you parse a JSON array [1.2, 1, 1.3]. You then get a class java.lang.Integer cannot be cast to class java.lang.Double when the element of the List is accessed as a Double.
