Run tests on PHP 8.4 and update test environment #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
force-pushed
the
1.x-PHP-8.4
branch
5 times, most recently
from
4653e70 to
c661f3e
Compare
WyriHaximus
force-pushed
the
1.x-PHP-8.4
branch
from
c661f3e to
38cde35
Compare
WyriHaximus
force-pushed
the
1.x-PHP-8.4
branch
3 times, most recently
from
8bb7003 to
8a1654f
Compare
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
WyriHaximus
force-pushed
the
1.x-PHP-8.4
branch
from
8a1654f to
27b6f63
Compare
clue
approved these changes
Oct 25, 2025
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Perfect, thanks for the update, changes LGTM, let's move forward with this! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #269, #270 and reactphp/socket#323 by backporting #279 to v1.