Block GHA migration view for SSO organization users #669
Conversation
This shows the user a verbose error message and blocks the view from being used for now, and points the user to contact support. From there, we can either help the user manually migrate or we can at least explain the limitation and follow up when we are ready to test support for dual-integration permission checks.
|
It took a bit to set up to test this, but this is what this looks like locally from a user in a GitHub SSO organization. The steps are disabled individually and can't be navigated to, though the view on the application side could still be used in theory. 
|
readthedocsext/theme/templates/profiles/private/migrate_to_gh_app.html
Outdated
Show resolved
Hide resolved
|
The changes in the querysets from https://github.com/readthedocs/readthedocs-corporate/pull/2057 worked. The user that was having problems with it already migrated 28 projects :D (I told him to just migrate one project at a time) |
|
We might want to then turn this PR into different warnings on the migration view. We probably want to block users from removing OAuth connections and we should warn about keeping the OAuth connection around. Perhaps this is even a job for the connected services page, we could disable removal of GitHub OAuth. |
This shows the user a verbose error message and blocks the view from
being used for now, and points the user to contact support. From there,
we can either help the user manually migrate or we can at least explain
the limitation and follow up when we are ready to test support for
dual-integration permission checks.