Skip to content

Update the sample code for the SOLID article #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the sample code for the SOLID article #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions solid-principles-python/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# SOLID Principles: Improve Object-Oriented Design in Python
# SOLID Design Principles: Improve Object-Oriented Code in Python

This folder provides the code examples for the Real Python tutorial [SOLID Principles: Improve Object-Oriented Design in Python](https://realpython.com/solid-principles-python/).
This folder contains the code examples for the Real Python article [SOLID Design Principles: Improve Object-Oriented Code in Python](https://realpython.com/solid-principles-python/).
4 changes: 4 additions & 0 deletions solid-principles-python/shapes_ocp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@
# self.height = kwargs["height"]
# elif self.shape_type == "circle":
# self.radius = kwargs["radius"]
# else:
# raise TypeError("Unsupported shape type")

# def calculate_area(self):
# if self.shape_type == "rectangle":
# return self.width * self.height
# elif self.shape_type == "circle":
# return pi * self.radius**2
# else:
# raise TypeError("Unsupported shape type")


# Good example
Expand Down