Add function evaluation count to minimize return values
#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces minimize_with_nevals to return both optimization results and the number of function evaluations. The original minimize function now omits evaluation count for backwards compatibility.
relf
requested changes
Oct 23, 2025
Owner
relf
left a comment
relf
left a comment
There was a problem hiding this comment.
Thanks for this contribution (I know why you want to do this! 😄).
I think I prefer the breaking change of adding a fourth return value instead of introducing a minimize_with_nevals which name is a bit ambiguous and somehow "double" the API surface.
Author
|
Does the first commit (4576a23) seem fine or would you like some other changes? |
Owner
|
Yes, the first commit is ok. |
Author
|
Hello, I no longer need this for my use case. Would you like me to revert to the first commit anyway to be able to merge, or should I close this PR? |
Owner
|
It 's ok, without any requirement, I prefer to keep it simple. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
minimizefunction and related types to include the number of function evaluations in its return values.