-
Notifications
You must be signed in to change notification settings - Fork 824
feat(demo): use Tailwind v4 in slack-confirm.tsx #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
6d1b7eb
to
1a0664f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 issues found across 4 files
Prompt for AI agents (all 4 issues)
Understand the root cause of the following 4 issues and fix them.
<file name="apps/demo/emails/magic-links/slack-confirm.tsx">
<violation number="1" location="apps/demo/emails/magic-links/slack-confirm.tsx:43">
The Tailwind preset backing this email doesn’t define my-7.5 or leading-10.5, so this heading renders without the intended spacing/line-height. Replace them with arbitrary values (e.g., my-[30px], leading-[42px]) so the styles survive compilation.</violation>
<violation number="2" location="apps/demo/emails/magic-links/slack-confirm.tsx:46">
mb-7.5 isn’t part of the Tailwind spacing scale from pixelBasedPreset, so this paragraph loses its bottom margin. Use an arbitrary value class like mb-[30px] instead.</violation>
<violation number="3" location="apps/demo/emails/magic-links/slack-confirm.tsx:51">
mb-7.5 isn’t defined in the active Tailwind preset, so this section renders without spacing beneath it. Swap it for an arbitrary pixel value (e.g., mb-[30px]) to match the intended layout.</violation>
<violation number="4" location="apps/demo/emails/magic-links/slack-confirm.tsx:142">
mb-12.5 isn’t generated by the Tailwind preset, so the footer text loses its bottom margin. Use an arbitrary pixel class such as mb-[50px] to preserve the layout.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
> | ||
Slack Community | ||
</Link> | ||
<Text className="text-xs text-left mb-12.5 text-[#b7b7b7]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb-12.5 isn’t generated by the Tailwind preset, so the footer text loses its bottom margin. Use an arbitrary pixel class such as mb-[50px] to preserve the layout.
Prompt for AI agents
Address the following comment on apps/demo/emails/magic-links/slack-confirm.tsx at line 142:
<comment>mb-12.5 isn’t generated by the Tailwind preset, so the footer text loses its bottom margin. Use an arbitrary pixel class such as mb-[50px] to preserve the layout.</comment>
<file context>
@@ -26,121 +28,127 @@ export const SlackConfirmEmail = ({
+ >
+ Slack Community
+ </Link>
+ <Text className="text-xs text-left mb-12.5 text-[#b7b7b7]">
+ ©2022 Slack Technologies, LLC, a Salesforce company. <br />
+ 500 Howard Street, San Francisco, CA 94105, USA <br />
</file context>
<Text className="text-xs text-left mb-12.5 text-[#b7b7b7]"> | |
<Text className="text-xs text-left mb-[50px] text-[#b7b7b7]"> |
<Section style={codeBox}> | ||
<Text style={confirmationCodeText}>{validationCode}</Text> | ||
</Section> | ||
<Section className="bg-[rgb(245,244,245)] rounded mb-7.5 py-10 px-2.5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb-7.5 isn’t defined in the active Tailwind preset, so this section renders without spacing beneath it. Swap it for an arbitrary pixel value (e.g., mb-[30px]) to match the intended layout.
Prompt for AI agents
Address the following comment on apps/demo/emails/magic-links/slack-confirm.tsx at line 51:
<comment>mb-7.5 isn’t defined in the active Tailwind preset, so this section renders without spacing beneath it. Swap it for an arbitrary pixel value (e.g., mb-[30px]) to match the intended layout.</comment>
<file context>
@@ -26,121 +28,127 @@ export const SlackConfirmEmail = ({
- <Section style={codeBox}>
- <Text style={confirmationCodeText}>{validationCode}</Text>
- </Section>
+ <Section className="bg-[rgb(245,244,245)] rounded mb-7.5 py-10 px-2.5">
+ <Text className="text-3xl text-center align-middle">
+ {validationCode}
</file context>
<Section className="bg-[rgb(245,244,245)] rounded mb-7.5 py-10 px-2.5"> | |
<Section className="bg-[rgb(245,244,245)] rounded mb-[30px] py-10 px-2.5"> |
<Heading className="text-[#1d1c1d] text-4xl font-bold my-7.5 mx-0 p-0 leading-10.5"> | ||
Confirm your email address | ||
</Heading> | ||
<Text className="text-xl mb-7.5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb-7.5 isn’t part of the Tailwind spacing scale from pixelBasedPreset, so this paragraph loses its bottom margin. Use an arbitrary value class like mb-[30px] instead.
Prompt for AI agents
Address the following comment on apps/demo/emails/magic-links/slack-confirm.tsx at line 46:
<comment>mb-7.5 isn’t part of the Tailwind spacing scale from pixelBasedPreset, so this paragraph loses its bottom margin. Use an arbitrary value class like mb-[30px] instead.</comment>
<file context>
@@ -26,121 +28,127 @@ export const SlackConfirmEmail = ({
+ <Heading className="text-[#1d1c1d] text-4xl font-bold my-7.5 mx-0 p-0 leading-10.5">
+ Confirm your email address
+ </Heading>
+ <Text className="text-xl mb-7.5">
+ Your confirmation code is below - enter it in your open browser
+ window and we'll help you get signed in.
</file context>
<Text className="text-xl mb-7.5"> | |
<Text className="text-xl mb-[30px]"> |
alt="Slack" | ||
/> | ||
</Section> | ||
<Heading className="text-[#1d1c1d] text-4xl font-bold my-7.5 mx-0 p-0 leading-10.5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Tailwind preset backing this email doesn’t define my-7.5 or leading-10.5, so this heading renders without the intended spacing/line-height. Replace them with arbitrary values (e.g., my-[30px], leading-[42px]) so the styles survive compilation.
Prompt for AI agents
Address the following comment on apps/demo/emails/magic-links/slack-confirm.tsx at line 43:
<comment>The Tailwind preset backing this email doesn’t define my-7.5 or leading-10.5, so this heading renders without the intended spacing/line-height. Replace them with arbitrary values (e.g., my-[30px], leading-[42px]) so the styles survive compilation.</comment>
<file context>
@@ -26,121 +28,127 @@ export const SlackConfirmEmail = ({
+ alt="Slack"
+ />
+ </Section>
+ <Heading className="text-[#1d1c1d] text-4xl font-bold my-7.5 mx-0 p-0 leading-10.5">
+ Confirm your email address
+ </Heading>
</file context>
<Heading className="text-[#1d1c1d] text-4xl font-bold my-7.5 mx-0 p-0 leading-10.5"> | |
<Heading className="text-[#1d1c1d] text-4xl font-bold my-[30px] mx-0 p-0 leading-[42px]"> |
Summary by cubic
Refactored the Slack magic link email in the demo to use Tailwind styles, aligning the template with the Tailwind setup.
Refactors
Dependencies