-
Notifications
You must be signed in to change notification settings - Fork 824
feat(demo): use Tailwind v4 in stack-overflow-tips.tsx #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chore/basic-setup
Are you sure you want to change the base?
feat(demo): use Tailwind v4 in stack-overflow-tips.tsx #2494
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
69aa0ce
to
5a4dfc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/demo/emails/tailwind.config.ts">
<violation number="1" location="apps/demo/emails/tailwind.config.ts:7">
The font stack spells the brand font as HelveticaNeue (no space), so the generated CSS can’t select `'Helvetica Neue'`. That forces the Stack Overflow email to fall back to plain Helvetica, breaking the intended typography across clients.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
presets: [pixelBasedPreset], | ||
theme: { | ||
fontFamily: { | ||
'stack-overflow': 'HelveticaNeue,Helvetica,Arial,sans-serif', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font stack spells the brand font as HelveticaNeue (no space), so the generated CSS can’t select 'Helvetica Neue'
. That forces the Stack Overflow email to fall back to plain Helvetica, breaking the intended typography across clients.
Prompt for AI agents
Address the following comment on apps/demo/emails/tailwind.config.ts at line 7:
<comment>The font stack spells the brand font as HelveticaNeue (no space), so the generated CSS can’t select `'Helvetica Neue'`. That forces the Stack Overflow email to fall back to plain Helvetica, breaking the intended typography across clients.</comment>
<file context>
@@ -2,4 +2,10 @@ import { pixelBasedPreset, type TailwindConfig } from '@react-email/components';
presets: [pixelBasedPreset],
+ theme: {
+ fontFamily: {
+ 'stack-overflow': 'HelveticaNeue,Helvetica,Arial,sans-serif',
+ 'stack-overflow-mono': 'Consolas,monospace',
+ },
</file context>
'stack-overflow': 'HelveticaNeue,Helvetica,Arial,sans-serif', | |
'stack-overflow': ['Helvetica Neue', 'Helvetica', 'Arial', 'sans-serif'], |
b8d9157
to
b53368d
Compare
e8821f2
to
42c4dcf
Compare
Summary by cubic
Switches the StackOverflow Tips demo email to Tailwind by adding the Tailwind provider and aligning dependencies. This enables Tailwind styling and ensures compatibility with Tailwind v4.1.
Refactors
Dependencies