-
Notifications
You must be signed in to change notification settings - Fork 826
feat(demo): use Tailwind v4 in github-access-token.tsx #2496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chore/basic-setup
Are you sure you want to change the base?
feat(demo): use Tailwind v4 in github-access-token.tsx #2496
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
adac49e
to
232d496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/demo/emails/tailwind.config.ts">
<violation number="1" location="apps/demo/emails/tailwind.config.ts:5">
Defining theme.fontFamily directly replaces Tailwind’s default families, so utilities like font-sans stop being generated. Add the new family under theme.extend.fontFamily instead of overwriting the defaults.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
|
||
export default { | ||
presets: [pixelBasedPreset], | ||
theme: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defining theme.fontFamily directly replaces Tailwind’s default families, so utilities like font-sans stop being generated. Add the new family under theme.extend.fontFamily instead of overwriting the defaults.
Prompt for AI agents
Address the following comment on apps/demo/emails/tailwind.config.ts at line 5:
<comment>Defining theme.fontFamily directly replaces Tailwind’s default families, so utilities like font-sans stop being generated. Add the new family under theme.extend.fontFamily instead of overwriting the defaults.</comment>
<file context>
@@ -2,4 +2,10 @@ import { pixelBasedPreset, type TailwindConfig } from '@react-email/components';
export default {
presets: [pixelBasedPreset],
+ theme: {
+ fontFamily: {
+ github:
</file context>
✅ Addressed in 8ae794a
b8d9157
to
b53368d
Compare
2ee73b8
to
363a533
Compare
b53368d
to
0c35f55
Compare
363a533
to
3f24cc5
Compare
bcd2dee
to
4aa08f5
Compare
2c12241
to
b876d4e
Compare
Summary by cubic
Refactored the GitHub access token demo email to use Tailwind for styling. This standardizes styles and aligns the demo with the Tailwind-compatible components.
Refactors
Dependencies