Skip to content

Conversation

bukinoshita
Copy link
Member

@bukinoshita bukinoshita commented Sep 29, 2025


Summary by cubic

Refactored the GitHub access token demo email to use Tailwind for styling. This standardizes styles and aligns the demo with the Tailwind-compatible components.

  • Refactors

    • Added Tailwind wrapper import in apps/demo/emails/notifications/github-access-token.tsx.
  • Dependencies

    • Updated @react-email/components to 1.0.0-tailwindv4.1.

Copy link

changeset-bot bot commented Sep 29, 2025

⚠️ No Changeset found

Latest commit: b876d4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-email Ready Ready Preview Comment Oct 7, 2025 8:51pm
react-email-demo Ready Ready Preview Comment Oct 7, 2025 8:51pm

Copy link

socket-security bot commented Sep 29, 2025

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

Copy link

alwaysmeticulous bot commented Oct 2, 2025

🤖 Meticulous was unable to start a test run because no sessions have been recorded yet. Click here to setup session recording.

Last updated for commit 2ee73b8. This comment will update as new commits are pushed.

@gabrielmfern gabrielmfern changed the base branch from canary to chore/basic-setup October 2, 2025 20:05
@gabrielmfern gabrielmfern changed the title refactor(demo): github with tailwind v Oct 2, 2025
@gabrielmfern gabrielmfern changed the title v github-access-token.tsx Oct 2, 2025
@gabrielmfern gabrielmfern changed the title github-access-token.tsx feat(demo): use Tailwind v4 in github-access-token.tsx Oct 2, 2025
@gabrielmfern gabrielmfern marked this pull request as ready for review October 2, 2025 20:29
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="apps/demo/emails/tailwind.config.ts">

<violation number="1" location="apps/demo/emails/tailwind.config.ts:5">
Defining theme.fontFamily directly replaces Tailwind’s default families, so utilities like font-sans stop being generated. Add the new family under theme.extend.fontFamily instead of overwriting the defaults.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.


export default {
presets: [pixelBasedPreset],
theme: {
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defining theme.fontFamily directly replaces Tailwind’s default families, so utilities like font-sans stop being generated. Add the new family under theme.extend.fontFamily instead of overwriting the defaults.

Prompt for AI agents
Address the following comment on apps/demo/emails/tailwind.config.ts at line 5:

<comment>Defining theme.fontFamily directly replaces Tailwind’s default families, so utilities like font-sans stop being generated. Add the new family under theme.extend.fontFamily instead of overwriting the defaults.</comment>

<file context>
@@ -2,4 +2,10 @@ import { pixelBasedPreset, type TailwindConfig } from &#39;@react-email/components&#39;;
 
 export default {
   presets: [pixelBasedPreset],
+  theme: {
+    fontFamily: {
+      github:
</file context>

✅ Addressed in 8ae794a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants