-
Notifications
You must be signed in to change notification settings - Fork 825
feat(demo): use Tailwind v4 in raycast-magic-link.tsx #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chore/basic-setup
Are you sure you want to change the base?
feat(demo): use Tailwind v4 in raycast-magic-link.tsx #2524
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/demo/emails/magic-links/raycast-magic-link.tsx">
<violation number="1" location="apps/demo/emails/magic-links/raycast-magic-link.tsx:44">
The new tailwind class leading-6.5 never gets generated: Tailwind’s default line-height scale (and this config) only exposes integer keys like 6 or 7, so the browser drops the class and the text falls back to the component’s default line-height instead of the intended 26px. Swap this for an arbitrary value (e.g. leading-[26px]) to match the original spacing.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
🪄 Your magic link | ||
</Heading> | ||
<Section className="my-6 mx-0"> | ||
<Text className="text-base leading-6.5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new tailwind class leading-6.5 never gets generated: Tailwind’s default line-height scale (and this config) only exposes integer keys like 6 or 7, so the browser drops the class and the text falls back to the component’s default line-height instead of the intended 26px. Swap this for an arbitrary value (e.g. leading-[26px]) to match the original spacing.
Prompt for AI agents
Address the following comment on apps/demo/emails/magic-links/raycast-magic-link.tsx at line 44:
<comment>The new tailwind class leading-6.5 never gets generated: Tailwind’s default line-height scale (and this config) only exposes integer keys like 6 or 7, so the browser drops the class and the text falls back to the component’s default line-height instead of the intended 26px. Swap this for an arbitrary value (e.g. leading-[26px]) to match the original spacing.</comment>
<file context>
@@ -25,47 +27,52 @@ export const RaycastMagicLinkEmail = ({
+ 🪄 Your magic link
+ </Heading>
+ <Section className="my-6 mx-0">
+ <Text className="text-base leading-6.5">
+ <Link className="text-[#FF6363]" href={magicLink}>
+ 👉 Click here to sign in 👈
</file context>
<Text className="text-base leading-6.5"> | |
<Text className="text-base leading-[26px]"> |
✅ Addressed in 8ae794a
b8d9157
to
b53368d
Compare
9da6877
to
8e24816
Compare
b53368d
to
0c35f55
Compare
8e24816
to
00c28c1
Compare
bcd2dee
to
4aa08f5
Compare
8f6fc1b
to
b4e6189
Compare
Summary by cubic
Migrated the Raycast magic link email to Tailwind v4 for React Email, replacing inline styles with utility classes for easier maintenance and consistent styling. Addresses Linear OSS-233.