Skip to content

Conversation

gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Oct 3, 2025

Meant to fix CI's tests failing in #2487 which is happening because these tests
depend on the demo's email templates.


Summary by cubic

Stop using demo email templates in tests to remove cross-package coupling and stabilize CI. Tests now rely on local fixtures for the Vercel invite email.

  • Bug Fixes
    • Added local VercelInviteUser email fixtures for preview-server and react-email testing.
    • Updated get-email-component.spec.ts to load the local template.
    • Updated export.spec.ts to use the local emails directory and new snapshot path.

@gabrielmfern gabrielmfern self-assigned this Oct 3, 2025
Copy link

changeset-bot bot commented Oct 3, 2025

⚠️ No Changeset found

Latest commit: 4b33f86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-email Ready Ready Preview Comment Oct 3, 2025 1:08pm
react-email-demo Ready Ready Preview Comment Oct 3, 2025 1:08pm

Copy link

pkg-pr-new bot commented Oct 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/@react-email/preview-server@2532
npm i https://pkg.pr.new/resend/react-email@2532

commit: 4b33f86

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@gabrielmfern gabrielmfern merged commit 8156477 into canary Oct 6, 2025
15 of 16 checks passed
@gabrielmfern gabrielmfern deleted the fix/tests-depending-on-demo branch October 6, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants