Skip to content

fix(udb): fix postgres driver impl #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(udb): fix postgres driver impl #3035

wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Oct 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ready Ready Preview Comment Oct 3, 2025 11:55pm
rivet-inspector Ready Ready Preview Comment Oct 3, 2025 11:55pm
rivet-site Ready Ready Preview Comment Oct 3, 2025 11:55pm

@claude Claude
Copy link

claude bot commented Oct 2, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Oct 2, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 2, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner@3035

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner-protocol@3035

commit: b9aa0d1

@MasterPtato MasterPtato force-pushed the 10-01-fix_udb_fix_postgres_driver_impl branch from baabddc to 7329d90 Compare October 2, 2025 16:45
@claude Claude
Copy link

claude bot commented Oct 2, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato force-pushed the 10-01-fix_udb_fix_postgres_driver_impl branch from 7329d90 to 570f2d3 Compare October 2, 2025 21:40
@claude Claude
Copy link

claude bot commented Oct 2, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato mentioned this pull request Oct 2, 2025
Open
@MasterPtato MasterPtato marked this pull request as ready for review October 2, 2025 22:01
@MasterPtato MasterPtato mentioned this pull request Oct 2, 2025
Open
graphite-app[bot]
graphite-app bot reviewed Oct 2, 2025
View reviewed changes
packages/common/universaldb/src/driver/postgres/transaction.rs
if self.committed.load(Ordering::SeqCst) {
return Ok(());
}
self.committed.store(true, Ordering::SeqCst);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving the committed.store(true, Ordering::SeqCst) line after the successful commit operation to prevent a potential race condition. If the commit fails, the transaction would be incorrectly marked as committed, which could lead to unexpected behavior in error recovery scenarios.

Spotted by Diamond

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

@MasterPtato MasterPtato force-pushed the 10-01-fix_udb_fix_postgres_driver_impl branch from 570f2d3 to 8e04f9c Compare October 3, 2025 00:35
@MasterPtato MasterPtato mentioned this pull request Oct 3, 2025
Open
@claude Claude
Copy link

claude bot commented Oct 3, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Oct 3, 2025
Open
Open
@MasterPtato MasterPtato force-pushed the 10-01-fix_udb_fix_postgres_driver_impl branch from 8e04f9c to b9aa0d1 Compare October 3, 2025 23:40
@claude Claude
Copy link

claude bot commented Oct 3, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MasterPtato