Skip to content

feat: actor datacenter #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: actor datacenter #3097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/app/data-providers/default-data-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ type CreateActor = Omit<InspectorCreateActor, "keys" | "key"> & {
runnerNameSelector: string;
key: string;
crashPolicy: CrashPolicy;
datacenter?: string;
};

const defaultContext = {
Expand Down
1 change: 1 addition & 0 deletions frontend/src/app/data-providers/engine-data-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ export const createNamespaceContext = ({
namespace,
name: data.name,
key: data.key,
datacenter: data.datacenter,
crashPolicy: data.crashPolicy,
runnerNameSelector: data.runnerNameSelector,
input: JSON.stringify(data.input),
Expand Down
14 changes: 5 additions & 9 deletions frontend/src/components/actors/dialogs/create-actor-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,9 @@ import { useDataProvider } from "../data-provider";
import * as ActorCreateForm from "../form/actor-create-form";
import { CrashPolicy } from "../queries";

interface ContentProps extends DialogContentProps {
namespace: string;
}
interface ContentProps extends DialogContentProps {}

export default function CreateActorDialog({
onClose,
namespace,
}: ContentProps) {
export default function CreateActorDialog({ onClose }: ContentProps) {
const { mutateAsync } = useMutation(
useDataProvider().createActorMutationOptions(),
);
Expand All @@ -44,6 +39,7 @@ export default function CreateActorDialog({
name: values.name,
input: values.input ? JSON.parse(values.input) : undefined,
key: values.key,
datacenter: values.datacenter,
crashPolicy: values.crashPolicy || CrashPolicy.Destroy,
runnerNameSelector: values.runnerNameSelector || "default",
});
Expand All @@ -52,7 +48,7 @@ export default function CreateActorDialog({
defaultValues={{
name,
crashPolicy: CrashPolicy.Destroy,
region: "auto",
datacenter: "auto",
}}
>
<DialogHeader>
Expand All @@ -75,7 +71,7 @@ export default function CreateActorDialog({
<AccordionContent className="flex gap-4 flex-col">
{["engine", "cloud"].includes(__APP_TYPE__) ? (
<>
<ActorCreateForm.Region />
<ActorCreateForm.Datacenter />
<ActorCreateForm.RunnerNameSelector />
<ActorCreateForm.CrashPolicy />
</>
Expand Down
12 changes: 6 additions & 6 deletions frontend/src/components/actors/form/actor-create-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ export const formSchema = z
input: jsonValid.optional(),
// tags: tagsFormSchema.shape.tags,

region: z.string(),
datacenter: z.string(),
runnerNameSelector: z.string(),
crashPolicy: z.nativeEnum(CrashPolicyEnum),
})
.partial({ region: true, runnerNameSelector: true, crashPolicy: true });
.partial({ datacenter: true, runnerNameSelector: true, crashPolicy: true });

export type FormValues = z.infer<typeof formSchema>;
export type SubmitHandler = (
Expand Down Expand Up @@ -239,24 +239,24 @@ export const PrefillRunnerName = () => {
return null;
};

export const Region = () => {
export const Datacenter = () => {
const { control } = useFormContext<FormValues>();

return (
<FormField
control={control}
name="region"
name="datacenter"
render={({ field }) => (
<FormItem>
<FormLabel>Region</FormLabel>
<FormLabel>Datacenter</FormLabel>
<FormControl>
<RegionSelect
value={field.value}
onValueChange={field.onChange}
/>
</FormControl>
<FormDescription>
The region where the Actor will be deployed.
The datacenter where the Actor will be deployed.
</FormDescription>
<FormMessage />
</FormItem>
Expand Down
Loading