Skip to content

fix(runner): handle ack events message #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(runner): handle ack events message #3108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/services/pegboard/src/workflows/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ pub const RUNNER_ELIGIBLE_THRESHOLD_MS: i64 = util::duration::seconds(10);
/// How long to wait after last ping before forcibly removing a runner from the database and deleting its
/// workflow, evicting all actors. Note that the runner may still be running and can reconnect.
const RUNNER_LOST_THRESHOLD_MS: i64 = util::duration::minutes(2);
/// Batch size of how many events to ack.
const EVENT_ACK_BATCH_SIZE: i64 = 500;

#[derive(Debug, Serialize, Deserialize, Clone)]
pub struct Input {
Expand Down Expand Up @@ -199,8 +201,12 @@ pub async fn pegboard_runner(ctx: &mut WorkflowCtx, input: &Input) -> Result<()>

state.last_event_idx = last_event_idx;

// Ack every 500 events
if last_event_idx > state.last_event_ack_idx.saturating_add(500) {
// Ack events in batch
if last_event_idx
> state
.last_event_ack_idx
.saturating_add(EVENT_ACK_BATCH_SIZE)
{
state.last_event_ack_idx = last_event_idx;

ctx.activity(SendMessageToRunnerInput {
Expand Down
106 changes: 54 additions & 52 deletions sdks/typescript/runner/src/mod.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading