Skip to content

fix(#941): CORS refusing connection from studio to local manager #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(#941): CORS refusing connection from studio to local manager #943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cefc87c
fix: apply cors only for non-websocket routes
jog1t Apr 26, 2025
ab5a4e7
fix: removes old cors settings
jog1t Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/actor-core/src/manager/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,16 @@ export function createManagerRouter(

// Apply CORS middleware if configured
if (appConfig.cors) {
app.use("*", cors(appConfig.cors));
app.use("*", async (c, next) => {
const path = c.req.path;

// Don't apply to WebSocket routes, see https://hono.dev/docs/helpers/websocket#upgradewebsocket
if (path === "/manager/inspect" && appConfig.inspector.enabled) {
return next();
}

return cors(appConfig.cors)(c, next);
});
}

app.get("/", (c) => {
Expand Down
Loading