#131 Give descriptive error when input images are too small to constrain PixelGrid #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parejkoj discovered that the PixelGrid model behaves very poorly if the input images are too small to constrain all of the pixels in a PixelGrid model. Rather than give an appropriate error, informing the user of the problem, it just attempts to do the fit anyway and tends to end up with an extremely bad fit.
This PR explicitly checks the image size of stars being used to constrain the model. If they are too small, they get flagged. And if all the stars are flagged, an error is raised. Appropriate logger messages are given for each, so hopefully this will clue the user in to what the problem is.