-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ntuple] automatic schema evolution of fixed-size array to std::vector #19997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 21 files 21 suites 3d 13h 57m 58s ⏱️ Results for commit c14ae13. ♻️ This comment has been updated with latest results. |
e7c892c
to
1157c9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intermediate RArrayAsBoolVectorField
implementation of use? If not, would it make sense to reorganize the commits?
e2933b9
to
6438d16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
6438d16
to
c14ae13
Compare
Substitute the RVectorField by an RArrayAsVectorField if a fixed-size array is found on disk.
Direct support of fixed-size on-disk arrays in the std::vector<bool> specialization. This is different from the general RVectorField case because the bool vector is much simpler to begin with and it is also already inherently slow.
c14ae13
to
5994ae1
Compare
No description provided.