Skip to content

Conversation

jblomer
Copy link
Contributor

@jblomer jblomer commented Sep 28, 2025

No description provided.

Copy link

github-actions bot commented Sep 28, 2025

Test Results

    21 files      21 suites   3d 13h 57m 58s ⏱️
 3 691 tests  3 691 ✅ 0 💤 0 ❌
75 636 runs  75 636 ✅ 0 💤 0 ❌

Results for commit c14ae13.

♻️ This comment has been updated with latest results.

@jblomer jblomer force-pushed the ntuple-array-as-vector branch from e7c892c to 1157c9d Compare September 29, 2025 07:18
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intermediate RArrayAsBoolVectorField implementation of use? If not, would it make sense to reorganize the commits?

@jblomer jblomer force-pushed the ntuple-array-as-vector branch 2 times, most recently from e2933b9 to 6438d16 Compare October 1, 2025 19:59
@jblomer jblomer requested a review from hahnjo October 1, 2025 20:00
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jblomer jblomer force-pushed the ntuple-array-as-vector branch from 6438d16 to c14ae13 Compare October 7, 2025 20:09
Substitute the RVectorField by an RArrayAsVectorField if a fixed-size
array is found on disk.
Direct support of fixed-size on-disk arrays in the std::vector<bool>
specialization. This is different from the general RVectorField case
because the bool vector is much simpler to begin with and it is also
already inherently slow.
@jblomer jblomer force-pushed the ntuple-array-as-vector branch from c14ae13 to 5994ae1 Compare October 8, 2025 06:20
@jblomer jblomer merged commit e4c6e2f into root-project:master Oct 8, 2025
24 of 26 checks passed
@jblomer jblomer deleted the ntuple-array-as-vector branch October 8, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants