Skip to content

[RF] Remove fallback to Minuit 1 in stressHistFactory #20036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

[RF] Remove fallback to Minuit 1 in stressHistFactory #20036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions roofit/histfactory/test/stressHistFactory.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include <TFile.h>
#include <TH1F.h>
#include <TMath.h>
#include <TMinuit.h>
#include <TString.h>
#include <TSystem.h>

Expand Down Expand Up @@ -428,24 +427,8 @@ class PdfComparison {
pVars1->assign(*pVars2);

// do the fit
std::string minimizerType = "Minuit2";
int prec = gErrorIgnoreLevel;
gErrorIgnoreLevel = kFatal;
if (gSystem->Load("libMinuit2") < 0)
minimizerType = "Minuit";
gErrorIgnoreLevel = prec;

std::unique_ptr<RooFitResult> r1{
rPDF1.fitTo(rTestData, Save(), PrintLevel(-1), Minimizer(minimizerType.c_str()))};
// L.M: for minuit we need to rest otherwise fit could fail
if (minimizerType == "Minuit") {
if (gMinuit) {
delete gMinuit;
gMinuit = nullptr;
}
}
std::unique_ptr<RooFitResult> r2{
rPDF2.fitTo(rTestData, Save(), PrintLevel(-1), Minimizer(minimizerType.c_str()))};
std::unique_ptr<RooFitResult> r1{rPDF1.fitTo(rTestData, Save(), PrintLevel(-1))};
std::unique_ptr<RooFitResult> r2{rPDF2.fitTo(rTestData, Save(), PrintLevel(-1))};

if (_verb > 0) {
r1->Print("v");
Expand Down
Loading