[RF] Avoid compute graph desync in RooFixedProdPdf #20040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
roofixedprodpdf
branch
from
ffbdfaf to
ac6f27c
Compare
The RooFixedProdPdf used an antipattern that should be avoided, and it was actually causing some problems in fits with the new CPU evaluation backend. The problem was that the class held on to some RooAbsArgs for its evaluation in some containers that were separate from RooFit server-client interface (the container was the `std::unique_ptr<RooProdPdf::CacheElem>`). This commit fixes the situation by avoiding this cache element member completely and consistently using the server proxies instead.
guitargeek
force-pushed
the
roofixedprodpdf
branch
from
ac6f27c to
80eeb3d
Compare
lmoneta
approved these changes
Oct 6, 2025
Test Results 22 files 22 suites 3d 17h 52m 54s ⏱️ For more details on these failures, see this check. Results for commit 80eeb3d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RooFixedProdPdf used an antipattern that should be avoided, and it was actually causing some problems in fits with the new CPU evaluation backend.
The problem was that the class held on to some RooAbsArgs for its evaluation in some containers that were separate from RooFit server-client interface (the container was the
std::unique_ptr<RooProdPdf::CacheElem>).This commit fixes the situation by avoiding this cache element member completely and consistently using the server proxies instead.