[ntuple] fix auto schema evolution of base classes #20041
+78
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forbid changing the number of base classes except for adding base classes where there were previously none and for removing all of the base classes.
jblomer
force-pushed
the
ntuple-evolution-shape
branch
from
58eddf8 to
379249b
Compare
pcanal
reviewed
Oct 6, 2025
Comment on lines
+530
to
+531
| GetTypeName() + ", " + std::to_string(nInMemoryBaseClasses) + " vs. " + | ||
| std::to_string(nOnDiskBaseClasses))); |
There was a problem hiding this comment.
Consider extending the text to clarify which number is for in memory and which number is for on file. It might also help to add version number (or checksum) of the class onfile layout.
pcanal
approved these changes
Oct 6, 2025
hahnjo
approved these changes
Oct 6, 2025
| nInMemoryBaseClasses++; | ||
| } | ||
|
|
||
| if (nInMemoryBaseClasses && nOnDiskBaseClasses && nInMemoryBaseClasses != nOnDiskBaseClasses) { |
There was a problem hiding this comment.
Maybe being explicit would make the condition even clearer?
Suggested change
| if (nInMemoryBaseClasses && nOnDiskBaseClasses && nInMemoryBaseClasses != nOnDiskBaseClasses) { | |
| if (nInMemoryBaseClasses != 0 && nOnDiskBaseClasses != 0 && nInMemoryBaseClasses != nOnDiskBaseClasses) { |
Test Results 22 files 22 suites 3d 16h 16m 58s ⏱️ Results for commit 379249b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbid changing the number of base classes except for adding base classes where there were previously none and for removing all of the base classes.