Skip to content

[v6.36][ntuple] enforce correct subfield name in untyped collection #20053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

[v6.36][ntuple] enforce correct subfield name in untyped collection #20053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tree/ntuple/src/RFieldSequenceContainer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ ROOT::RVectorField::RVectorField(std::string_view fieldName, std::unique_ptr<RFi
std::unique_ptr<ROOT::RVectorField>
ROOT::RVectorField::CreateUntyped(std::string_view fieldName, std::unique_ptr<RFieldBase> itemField)
{
return std::unique_ptr<ROOT::RVectorField>(new RVectorField(fieldName, std::move(itemField), true));
return std::unique_ptr<ROOT::RVectorField>(new RVectorField(fieldName, itemField->Clone("_0"), true));
}

std::unique_ptr<ROOT::RFieldBase> ROOT::RVectorField::CloneImpl(std::string_view newName) const
Expand Down
2 changes: 1 addition & 1 deletion tree/ntupleutil/v7/src/RNTupleImporter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@ ROOT::RResult<void> ROOT::Experimental::RNTupleImporter::PrepareSchema()

c.fFieldName = "_collection" + std::to_string(iLeafCountCollection);
auto recordField = std::make_unique<ROOT::RRecordField>("_0", std::move(c.fLeafFields));
c.fRecordField = recordField.get();
auto collectionField = ROOT::RVectorField::CreateUntyped(c.fFieldName, std::move(recordField));
c.fRecordField = static_cast<RRecordField *>(collectionField->GetMutableSubfields()[0]);
fModel->AddField(std::move(collectionField));

// Add projected fields for all leaf count arrays
Expand Down
Loading