Removed action tutorials interfaces dependency #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
clalancette
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
This one looks good to me. In the current code, this will get pulled in automatically via action_tutorials_cpp and action_tutorials_py, and after ros2/demos#701 it will stop getting pulled in. So this should be safe to do. I'm going to go ahead and merge this one right now.
clalancette
deleted the
ahcorde/rolling/remove_action_tutorials_interfaces
branch
clalancette
added a commit
to ros-infrastructure/rep
that referenced
this pull request
Oct 9, 2024
It was removed in ros2/demos#701 (since it was a duplicate with some other packages), and then further removed from the variants in ros2/variants#44, so that should be reflected here as well. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
added a commit
to ros-infrastructure/rep
that referenced
this pull request
Oct 9, 2024
…409) It was removed in ros2/demos#701 (since it was a duplicate with some other packages), and then further removed from the variants in ros2/variants#44, so that should be reflected here as well. Signed-off-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with ros2/demos#701 (comment) and ros2/demos#702