[variant] Make structural type and some testing #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaraslaut
force-pushed
the
variant/make_structural
branch
from
70a811c to
c069117
Compare
Tsche
requested changes
Nov 10, 2025
Yaraslaut
force-pushed
the
variant/make_structural
branch
from
c069117 to
23791e1
Compare
Tsche
approved these changes
Nov 11, 2025
Tsche
requested changes
Nov 11, 2025
Member
Tsche
left a comment
Tsche
left a comment
There was a problem hiding this comment.
please remove redundant public: specifiers
Yaraslaut
force-pushed
the
variant/make_structural
branch
from
23791e1 to
0146842
Compare
Member
Author
removed |
Tsche
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn
rsl::variantinto structural type and create a test case when we can use it as a template parameter