-
Notifications
You must be signed in to change notification settings - Fork 59
OIDC doc update #475 #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OIDC doc update #475 #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments; LGTM on my side, but I'll leave the approval to someone with more context on OIDC
|
LGTM, I leave signoff to @dchristidis |
|
ping on this @dchristidis ? |
|
It's been a few months, I think we can merge this. @rdimaio ? |
|
The main PR : rucio/rucio#7310 never got reviewed and thus missed the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Just have a few questions
| auth_type = oidc | ||
| oidc_polling = True | ||
| oidc_issuer=\<issuer's_nickname> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also wanted to check: Can all configurable settings be overridden using environment variables? If so, it might make sense to either update this documentation page or create a separate document listing all the environment variables just to keep things clear and well-organized.
Update token doc for server (single vo and multi vo) and client .
According to changes from parent issue : rucio/rucio#7310