Skip to content

Conversation

@voetberg
Copy link
Contributor

Partially closes #499

Rest would need to be addressed with changes to core.

@voetberg voetberg force-pushed the 499-daemon-args branch 2 times, most recently from 1474e4b to 7a392c5 Compare May 22, 2025 16:04
rdimaio
rdimaio previously approved these changes May 22, 2025
Copy link
Contributor

@rdimaio rdimaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure what's going on with the CI

@Geogouz
Copy link
Contributor

Geogouz commented May 22, 2025

LGTM, not sure what's going on with the CI

YAML parsing problems.
We could use maybe multi-line YAML strings to avoid parser confusion?

namely for example here, go from:

description: defines how to handle datasets: `fifo` (each file released separately) or `grouped_fifo` (wait for the entire dataset to fit)

to something like:

description: |
  defines how to handle datasets: `fifo` (each file released separately)
  or `grouped_fifo` (wait for the entire dataset to fit)

@rdimaio
Copy link
Contributor

rdimaio commented May 22, 2025

LGTM, not sure what's going on with the CI

YAML parsing problems. We could use maybe multi-line YAML strings to avoid parser confusion?

namely for example here, go from:

description: defines how to handle datasets: `fifo` (each file released separately) or `grouped_fifo` (wait for the entire dataset to fit)

to something like:

description: |
  defines how to handle datasets: `fifo` (each file released separately)
  or `grouped_fifo` (wait for the entire dataset to fit)

Yeah, I think ideally it would be best to fix this on the doc generation side, rather than having to think about this whenever we write docstrings in the main code

@voetberg
Copy link
Contributor Author

LGTM, not sure what's going on with the CI

YAML parsing problems. We could use maybe multi-line YAML strings to avoid parser confusion?
namely for example here, go from:

description: defines how to handle datasets: `fifo` (each file released separately) or `grouped_fifo` (wait for the entire dataset to fit)

to something like:

description: |
  defines how to handle datasets: `fifo` (each file released separately)
  or `grouped_fifo` (wait for the entire dataset to fit)

Yeah, I think ideally it would be best to fix this on the doc generation side, rather than having to think about this whenever we write docstrings in the main code

Ideally this should be caught by tools/check_rest_api_documentation.sh in the main repo - is there a reason that isn't run as part of the testing suite? It's use is described in our developer docs

@rdimaio
Copy link
Contributor

rdimaio commented May 23, 2025

LGTM, not sure what's going on with the CI

YAML parsing problems. We could use maybe multi-line YAML strings to avoid parser confusion?
namely for example here, go from:

description: defines how to handle datasets: `fifo` (each file released separately) or `grouped_fifo` (wait for the entire dataset to fit)

to something like:

description: |
  defines how to handle datasets: `fifo` (each file released separately)
  or `grouped_fifo` (wait for the entire dataset to fit)

Yeah, I think ideally it would be best to fix this on the doc generation side, rather than having to think about this whenever we write docstrings in the main code

Ideally this should be caught by tools/check_rest_api_documentation.sh in the main repo - is there a reason that isn't run as part of the testing suite? It's use is described in our developer docs

We could add that to the main repo's CI, but is there no way to fix this on the generation side, e.g. ignoring every colon after the first?

@Geogouz
Copy link
Contributor

Geogouz commented May 23, 2025

LGTM, not sure what's going on with the CI

YAML parsing problems. We could use maybe multi-line YAML strings to avoid parser confusion?
namely for example here, go from:

description: defines how to handle datasets: `fifo` (each file released separately) or `grouped_fifo` (wait for the entire dataset to fit)

to something like:

description: |
  defines how to handle datasets: `fifo` (each file released separately)
  or `grouped_fifo` (wait for the entire dataset to fit)

Yeah, I think ideally it would be best to fix this on the doc generation side, rather than having to think about this whenever we write docstrings in the main code

Ideally this should be caught by tools/check_rest_api_documentation.sh in the main repo - is there a reason that isn't run as part of the testing suite? It's use is described in our developer docs

We could add that to the main repo's CI, but is there no way to fix this on the generation side, e.g. ignoring every colon after the first?

We can maybe continue about it here #567

Co-authored-by: Riccardo Di Maio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add docs for daemon arguments

5 participants