Skip to content

Conversation

no111u3
Copy link
Contributor

@no111u3 no111u3 commented Nov 2, 2019

I update package to buildable on everything platforms

Use Infallible error type instead ()
Replace Void with core::convert::Infallible
Fix tests
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ithinuel (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Nov 2, 2019
@thejpster
Copy link
Contributor

Hi! Thanks for the PR. I'm afraid I don't really understand your opening comment, and this seems like a duplicate of #150 so I'd like to get that one in first. Then we can pick up the update to the stm32 crate.

@no111u3 no111u3 closed this Nov 2, 2019
@no111u3
Copy link
Contributor Author

no111u3 commented Nov 2, 2019

@thejpster Sorry, my mistake. I reupdate my pull request. I include #150 because it remove unneeded dependecies from project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Review is incomplete T-hal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants