More clearly define the default abi of an extern block #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
force-pushed
the
extern-default
branch
from
10f83c5 to
55c703d
Compare
tshepang
reviewed
Sep 17, 2025
ehuss
force-pushed
the
extern-default
branch
from
55c703d to
905bf34
Compare
traviscross
force-pushed
the
extern-default
branch
from
905bf34 to
62c0887
Compare
This comment has been minimized.
This comment has been minimized.
This attempts to make it clearer that if the ABI string is not specified, it defaults to the "C" ABI. I felt like the existing text didn't emphasize that enough. I also took the opportunity to reword the intro to more generally explain what the ABI string does. A followup PR will further clarify some of the confusing use of the word "default" in the specific ABI definitions.
traviscross
force-pushed
the
extern-default
branch
from
62c0887 to
717176c
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
traviscross
force-pushed
the
extern-default
branch
3 times, most recently
from
c265b9b to
88713f1
Compare
Rather than using an `abbr` tag when mentioning ABI, let's add a glossary entry for ABI and link to that.
traviscross
force-pushed
the
extern-default
branch
from
88713f1 to
fefcd8e
Compare
traviscross
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to make it clearer that if the ABI string is not specified, it defaults to the "C" ABI. I felt like the existing text didn't emphasize that enough.
I also took the opportunity to reword the intro to more generally explain what the ABI string does.
A followup PR will further clarify some of the confusing use of the word "default" in the specific ABI definitions.
This is implemented in
ExternAbi::FALLBACK