Build rust-analyzer with --target for install/pgo xtask
#20804
Merged
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
itsjunetime
changed the title
--target for install/pgo xtask
itsjunetime
force-pushed
the
run_correct_pgo_r-a
branch
from
8ea606f to
359a91e
Compare
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pgo xtask expects to find the recently-compiled version of rust-analyzer at
/target/$target/release/rust-analyzer, but theinstallxtask builds it without the--target $targetflag, thus placing it at/target/release/rust-analyzer.This PR adds the
--target $targetargument to the compilation of rust-analyzer in theinstallxtask so it works as expected.It also checks to make sure pgo actually generates files, and fails with a more actionable error (instead of the previous misleading
Do you have the rustup llvm-tools component installed?suggestion) when no files are generated.