Skip to content

Add self param completions for trait assoc fn #20812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add self param completions for trait assoc fn #20812

wants to merge 1 commit into from

Conversation

A4-Tacks
Copy link
Contributor

@A4-Tacks A4-Tacks commented Oct 8, 2025

Example

trait A {
    fn foo(file_id: usize) {}
    fn new($0) {}
}

Before this PR:

bn file_id: usize
kw mut
kw ref

After this PR:

bn &mut self
bn &self
bn file_id: usize
bn mut self
bn self
kw mut
kw ref

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2025
@A4-Tacks
Add self param completions for trait assoc fn
bd2f701 
Example
---
```rust
trait A {
    fn foo(file_id: usize) {}
    fn new($0) {}
}
```

**Before this PR**:

```text
bn file_id: usize
kw mut
kw ref
```

**After this PR**:

```text
bn &mut self
bn &self
bn file_id: usize
bn mut self
bn self
kw mut
kw ref
```
@A4-Tacks A4-Tacks force-pushed the comp-trait-self-param branch from d7b30a5 to bd2f701 Compare October 8, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A4-Tacks @rustbot