Skip to content

Conversation

tshepang
Copy link
Member

These were not updated after a bootstrap change where std cannot be built with stage0 rustc

@tshepang tshepang marked this pull request as ready for review September 29, 2025 16:58
@rustbot
Copy link
Collaborator

rustbot commented Sep 29, 2025

Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using r? rustc-dev-guide or r? <username>.

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Sep 29, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment on lines 225 to 231
Once you've created a `bootstrap.toml`, you are now ready to run
`x`. There are a lot of options here, but let's start with what is
probably the best "go to" command for building a local compiler:

```bash
./x build library
```console
./x build rustc
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: hm, I wonder if we should suggest ./x build library for producing a stage 1 rustc/std toolchain instead. But anyway, not for this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, an earlier version of this pr had that command... I think I should do that, since what we have here does not quite match the text that follows

jieyouxu

This comment was marked as duplicate.

@jieyouxu jieyouxu merged commit 8101650 into main Oct 4, 2025
1 check passed
@rustbot rustbot removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Oct 4, 2025
@jieyouxu jieyouxu deleted the tshepang-patch-5 branch October 4, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants