-
Notifications
You must be signed in to change notification settings - Fork 984
Concurrent downloads & installation #4570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It compiles, but I believe there is an infinite loop; at least, I could not get any toolchain installation to finish as it seemed to hang on the download of the last component. Additionally, I would like to note that when a component is being installed, although ongoing downloads continue normally, new component downloads cannot start. This isn’t an issue when Finally, I would like to point out that running both downloads and installations on the same thread prevents the progress bars for other downloads from updating (see here). |
|
I've fixed this up so that it can at least pass basic manual tests. CI is failing because I changed the log output -- happy to fix this up if we decide that we want to move forward with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works out pretty well during both code inspection and manual tests, so I consider this to be a somewhat faithful reproduction of the first step of #4471. Given that, I agree with merging this despite the fact that the project will suffer from temporary UX regressions.
I'd like to invite @FranciscoTGouveia do another round of review from his side to make sure everything is retained from the original solution.
|
Here's what I think we could do next to solve the remaining UX problem and even further improve the UX:
(A more principled approach might be to use |
This is what I had in mind. It seems to compile but I've done no testing or benchmarking.
@FranciscoTGouveia maybe that's something you can have a look at?
Alternative to
Obsoletes