-
Notifications
You must be signed in to change notification settings - Fork 63
Add support for Arm64EC and testing for Arm64 Windows #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "stacker" | ||
version = "0.1.21" | ||
version = "0.1.22" | ||
edition = "2021" | ||
rust-version = "1.63" | ||
authors = ["Alex Crichton <[email protected]>", "Simonas Kazlauskas <[email protected]>"] | ||
|
@@ -25,14 +25,22 @@ cfg-if = "1.0.0" | |
libc = "0.2.156" | ||
psm = { path = "psm", version = "0.1.7" } | ||
|
||
[target.'cfg(windows)'.dependencies.windows-sys] | ||
[target.'cfg(all(windows, not(target_arch = "arm64ec")))'.dependencies.windows-sys] | ||
version = ">=0.52.0, <0.60.0" | ||
features = [ | ||
"Win32_System_Memory", | ||
"Win32_System_Threading", | ||
"Win32_Foundation", | ||
] | ||
|
||
[target.arm64ec-pc-windows-msvc.dependencies.windows-sys] | ||
version = ">=0.59.0, <0.60.0" | ||
features = [ | ||
"Win32_System_Memory", | ||
"Win32_System_Threading", | ||
"Win32_Foundation", | ||
] | ||
|
||
|
||
[build-dependencies] | ||
cc = "1.1.22" | ||
cc = "1.2.33" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,4 +14,4 @@ readme = "README.mkd" | |
[dependencies] | ||
|
||
[build-dependencies] | ||
cc = "1.1.22" | ||
cc = "1.2.33" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
AREA |.text|, CODE, READONLY | ||
|
||
GLOBAL |#rust_psm_stack_direction| | ||
ALIGN 4 | ||
|#rust_psm_stack_direction| PROC | ||
orr w0, wzr, #2 | ||
ret | ||
ENDP | ||
|
||
|
||
GLOBAL |#rust_psm_stack_pointer| | ||
ALIGN 4 | ||
|#rust_psm_stack_pointer| PROC | ||
mov x0, sp | ||
ret | ||
ENDP | ||
|
||
|
||
GLOBAL |#rust_psm_replace_stack| | ||
ALIGN 4 | ||
|#rust_psm_replace_stack| PROC | ||
mov sp, x2 | ||
br x1 | ||
ENDP | ||
|
||
GLOBAL |#rust_psm_on_stack| | ||
ALIGN 4 | ||
|#rust_psm_on_stack| PROC | ||
stp x29, x30, [sp, #-16]! | ||
mov x29, sp | ||
mov sp, x3 | ||
blr x2 | ||
mov sp, x29 | ||
ldp x29, x30, [sp], #16 | ||
ret | ||
ENDP | ||
|
||
END | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the difference between this target and the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Difference is the name of the functions: Arm64EC requires that functions are prefixed with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not bump
windows-sys
dep accordingly for all windows targets?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with doing that, although I think that will be a semver breaking change. Let me know if that's what you prefer.