ISA-L compression support evaluation. #1908
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick test for re-evaluation of ISA-L support
see #1780
I ran samtools view on the current repository using libdeflate:
And then using the below patch with ISA-L.
This is significantly faster (slightly less than 2X) with a marginally larger filesize. And this is only the compression, I haven't tested decompression yet.
This needs to be properly integrated in the build system if this is going to be properly supported, so for now it is just hacked in to allow for benchmarks. (Install libisal-dev to compile on linux).