Set docs workflows in order #544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently they are .yaml while rest of the workflows are .yml. Let's set it inline with the rest.
dkropachev
force-pushed
the
dk/set-docs-workflows-in-order
branch
from
f83c592 to
c9a30ad
Compare
Lorak-mmk
requested changes
Sep 26, 2025
1. Trigger docs PR check on push to master and on PR events when it contains relevant changes 2. Include workflow files into triggering conditions
`actions/setup-python` poetry cache feature requires poetry to be installed beforehand. It makes use of it extremely awkward. That is why `action/cache` is used istead.
dkropachev
force-pushed
the
dk/set-docs-workflows-in-order
branch
2 times, most recently
from
8e22810 to
9cb5785
Compare
In order make docs build reproducible we need to lock poetry version. It will also help with pip cache invalidation on the pipeline, hash will be calculated from `docs/pyproject.toml`. Does two things: 1. Lock poetry version in `docs/pyproject.toml` 2. Pull version from `docs/pyproject.toml` in `Makefile`
dkropachev
force-pushed
the
dk/set-docs-workflows-in-order
branch
from
9cb5785 to
370c01a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
.yamlto.yml.docs/pyproject.toml.I added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.