-
Notifications
You must be signed in to change notification settings - Fork 49
Add LWT support #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add LWT support #584
Conversation
35e4bcb to
c9c6ed6
Compare
|
@dkropachev This test keeps failing |
c9c6ed6 to
95a453b
Compare
It is some weird bug, it is also failing on my branch. |
dkropachev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, there are some minor changes needed
|
@sylwiaszunejko, you also forgot to address batch statement part, but before we go there, could you please run tests for all the cases from https://github.com/scylladb/scylla-drivers/issues/117 and post findings there, after we can discuss what API should look like. |
WDYM by batch statements? AFAIU batch statement cannot be lwt or not as a whole |
They can have serial consistency, which means that they will work same way LWT statements work on the backend. |
95a453b to
6e56e3a
Compare
6e56e3a to
df027bf
Compare
Let's don't cover batch statements in this PR, we need to test how it works first |
df027bf to
0ac7a8e
Compare
Fixes: #476, #475