Skip to content

Conversation

@sylwiaszunejko
Copy link
Collaborator

@sylwiaszunejko sylwiaszunejko commented Nov 13, 2025

Fixes: #476, #475

@sylwiaszunejko sylwiaszunejko marked this pull request as ready for review November 13, 2025 16:37
@sylwiaszunejko
Copy link
Collaborator Author

@dkropachev This test keeps failing test_create_session_and_check_system_views_clients even though I haven't change any logic around it, do you have any idea why can this happen?

@dkropachev
Copy link
Collaborator

@dkropachev This test keeps failing test_create_session_and_check_system_views_clients even though I haven't change any logic around it, do you have any idea why can this happen?

It is some weird bug, it is also failing on my branch.

Copy link
Collaborator

@dkropachev dkropachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, there are some minor changes needed

@dkropachev
Copy link
Collaborator

dkropachev commented Nov 14, 2025

@sylwiaszunejko, you also forgot to address batch statement part, but before we go there, could you please run tests for all the cases from https://github.com/scylladb/scylla-drivers/issues/117 and post findings there, after we can discuss what API should look like.

@sylwiaszunejko
Copy link
Collaborator Author

sylwiaszunejko commented Nov 17, 2025

@sylwiaszunejko, you also forgot to address batch statement part, but before we go there, could you please run tests for all the cases from scylladb/scylla-drivers#117 and post findings there, after we can discuss what API should look like.

WDYM by batch statements? AFAIU batch statement cannot be lwt or not as a whole

@dkropachev
Copy link
Collaborator

dkropachev commented Nov 17, 2025

@sylwiaszunejko, you also forgot to address batch statement part, but before we go there, could you please run tests for all the cases from scylladb/scylla-drivers#117 and post findings there, after we can discuss what API should look like.

WDYM by batch statements? AFAIU batch statement cannot be lwt or not as a whole

They can have serial consistency, which means that they will work same way LWT statements work on the backend.
I know that if one statement of the batch is LWT then whole batch is going to have serial consistency.

@dkropachev
Copy link
Collaborator

@sylwiaszunejko, you also forgot to address batch statement part, but before we go there, could you please run tests for all the cases from scylladb/scylla-drivers#117 and post findings there, after we can discuss what API should look like.

WDYM by batch statements? AFAIU batch statement cannot be lwt or not as a whole

They can have serial consistency, which means that they will work same way LWT statements work on the backend. I know that if one statement of the batch is LWT then whole batch is going to have serial consistency.

Let's don't cover batch statements in this PR, we need to test how it works first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement SCYLLA_LWT_ADD_METADATA_MARK feature

2 participants