-
Notifications
You must be signed in to change notification settings - Fork 0
Add Google OAuth2 based authentication #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
varun-r-mallya
wants to merge
23
commits into
main
Choose a base branch
from
varun-r-mallya/google-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute does not check for unique enrollment number. other routes not tested. merge conflicts expected due to severe breaking changes
Sync main and dev
WIP commit with register and login routes working. issue: register ro…
Signed-off-by: Rizul Gupta <[email protected]>
…WARNING CONTAINS GOOGLE AUTH CREDS
Merge pls :) |
@Darkhood148 you also review works fine from my side |
Signed-off-by: Darkhood148 <[email protected]>
Adds env reader LGTM
Dotenv k alava env reader dependencies hta do. Then merge. GTG mere side se |
…database connection for development; remove unnecessary dependencies.
add id in response of give_put_url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Authentication complete
Problems:
Documentation:
Authentication routes and pipeline configuration.
Routes
The
/auth
scope handles authentication-related endpoints:*
GET /auth/ping
- Basic connectivity check*
GET /auth/google
- Initiates Google OAuth flow (To test, on your browser, visitlocalhost:4000/auth/google
)*
GET /auth/google/callback
- Handles Google OAuth callback (Frontend people don't have to deal with this)*
GET /auth/logout
- Handles user logout (Just GET this to logout)Pipeline
The
:authenticated_api
pipeline provides authentication middleware:* Accepts JSON requests
* Enables session handling
* Authenticates requests via AuthPlug
NOTES:
Automatically adds cookie to the browser and does auth check