Viewer side Voice Moderation Functionality #4759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or each possible action for now
… path :( - so mute/un mute and make this action and the moderation floater communicate changes with each other
…allum/voice-moderation
…. Implementation TBD but eventuaLLY, this will let moderators see who has been loud/disruptive (sorted by descending loudness on open) and mute them accordingly
…a capability to send a request to the simulator. Functionality will expand once this is confirmed to be working
…allum/voice-moderation
… IDs in the list for debuggiung
…allum/voice-moderation
akleshchev
reviewed
Oct 8, 2025
|
|
||
| if (LLAvatarPropertiesProcessor::instanceExists()) | ||
| { | ||
| LLAvatarPropertiesProcessor::getInstance()->removeObserver(avatar_data->avatar_id, this); |
There was a problem hiding this comment.
You also need to remove observer in destructor in case viewer/floater shuts down before response arrives.
There was a problem hiding this comment.
instanceExists check is only relevant for destructor, if we got processProperties, it exists.
There was a problem hiding this comment.
Ah noted and thank you - I suspect this floater will go away soon depending on what's in Steeltoe's UX design.
Thanks for the heads up and I will address if it does indeed persist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of Viewer side Voice moderation tools for WebRTC work.
There are 2 parts to the UI - a floater (might change to a panel/tab) that contains a richer set of moderation tools on 1 or many avatars. There is also a simple right-click context menu for performing moderation on a single avatar.
Very much a work in progress - and in need of product/ux/ui help.
Viewer portion of design doc can be found here