overhaul asset builds to support newer postgres and ruby env #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JFYI, it's libpq not libpg (Q not G for the last character) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
RuboCop passes
Existing tests pass
Purpose
User request to have asset work with postgres SCRAM password authentication algorithm introduced in postgresl 10.
Major overhaul of asset builds to build against postgres 12 for all linux platform targets instead of relying on os host postgres packages ( long term stable releases have postgres 9.x and libpg doesn't support SCRAM)
Since this is a major overhaul this is also an opportunity to move the ruby26 runtime as the ruby24 runtime is EOL upstream now.
Known Compatibility Issues
the libpg ABI should not be impacted, so there should not be a compatibility issue. However to be safe this should be considered a breaking change and version should be major release bump.