🦸♂️ 🦸♀️ 🦸 #1
Open
🦸♂️ 🦸♀️ 🦸 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klay964
reviewed
Sep 4, 2023
| const handleTabSelect = (tab) => setCurrentTab(tab); | ||
|
|
||
|
|
||
| const generateTabContent = (tab) => { |
There was a problem hiding this comment.
loved how you used a switch case for this kind of condition that involves several situations and also how you used it to render components
klay964
reviewed
Sep 4, 2023
| @@ -0,0 +1,37 @@ | |||
| import React, { useEffect, useState , useContext } from "react"; | |||
klay964
reviewed
Sep 4, 2023
|
|
||
| const keysToDisplay = ["relatives", "group-affiliation"]; | ||
|
|
||
| const shortenText = (str) => { |
There was a problem hiding this comment.
make a separate folder called utils or helpers and make a file that contains all helper functions like this one and write it their and import it to use it here
klay964
reviewed
Sep 4, 2023
| @@ -0,0 +1,24 @@ | |||
|
|
|||
There was a problem hiding this comment.
great job making the services folder to handle dealing with the api !
klay964
reviewed
Sep 4, 2023
|
|
||
| const token = process.env.REACT_APP_TOKEN; | ||
|
|
||
| const BASE_URL = `https://superheroapi.com/api.php/${token}` |
There was a problem hiding this comment.
save the API URL inside the env file too
klay964
reviewed
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.