Skip to content

Magento 2.4.7: Fix parent constructor call in Abandoned Grid #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Magento 2.4.7: Fix parent constructor call in Abandoned Grid #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Block/Adminhtml/Shopcart/Abandoned/Grid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function __construct(
) {
$this->jsonSerializer = $jsonSerializer;
$this->configHelper = $configHelper;
parent::__construct($context, $backendHelper, $quotesFactory, $data);
parent::__construct($context, $backendHelper, $quotesFactory, null, null, $data);
Copy link

@mantis4444 mantis4444 May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro, you need to check the parent. You have to pass $urlDecoder and $parameters, not null. It will not break because parent constructs them anyways in case of null. Still better to keep the flexibility and do it correctly.

}

/**
Expand Down