fix Sui e2e test #20156
fix Sui e2e test #20156
Conversation
|
|
||
| paramValues := []any{ | ||
| decodedTokenReceiver, | ||
| msg.TokenReceiverATA, |
There was a problem hiding this comment.
we probably have to change existing ccip tests inputs then
Also in what cases will msg.Reciever != tokenReciever?
There was a problem hiding this comment.
this is only possible when sending tokens to Sui or Solana bc in their extra args, we define a token receiver field.
There was a problem hiding this comment.
hmm so we probably won't be sending tokens to SUI from SUI. So msg.Reciever != tokenReciever only applies to solana case then?
There was a problem hiding this comment.
yes. but when it's a pure token transfer, we should not set msg.receiver, right? we should only set token receiver in extra args in that case.
FelixFan1992
requested review from
0xAustinWang,
asoliman92,
chris-de-leon-cll,
matYang,
mateusz-sekara,
ogtownsend and
winder
product-security-plaid-production
bot
requested review from
ChrisAmora,
DimitriosNaikopoulos,
ajaskolski,
bytesizedroll,
cedric-cordenier,
giogam,
graham-chainlink and
jkongie
| ExtraArgs: extraArgs, | ||
| FeeToken: feeToken, | ||
| TokenAmounts: tokens.([]SuiTokenAmount), | ||
| TokenReceiverATA: common.LeftPadBytes(tokenReceiverATA, 32), |
There was a problem hiding this comment.
is this just set to empty for now? I don't see any test where this value is non zero
There was a problem hiding this comment.
they are used in those test cases at line 416 of ccip_sui_token_transfer_test.go. before this, they won't be passed in properly.
There was a problem hiding this comment.
Line 416 of ccip_sui_token_transfer_test.go is test from EVM -> SUI tho, whereas the above change seems like it's impacting SUI -> EVM
There was a problem hiding this comment.
tokenRecieverATA is just suiAddress EOA that recieves the token on destination chain
…chainlink into fix-sui-e2e-test
|
4 participants
Requires
Supports