Updating documentation for Preset names and Preset 0. #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A current problem we're having is that there's no consistent documentation with preset 0. Should it be first in the preset list or last? This matters if you're setting custom preset names, since the app just sends an array of strings to name the presets. So if preset 0 is in the wrong spot, it throws off all the preset names. Currently Pandora considers it as preset 10 vs iHeartRadio considers it as preset 0. This came up because we've never had a sync that can use 10 presets AND show the preset label. sync3 only does presets 1-8 and shows labels. sync1 does 10 presets but no labels
Author
|
@theresalech can you give this a review plz? |
theresalech
requested changes
Sep 30, 2020
Contributor
theresalech
left a comment
theresalech
left a comment
There was a problem hiding this comment.
@MichaelCrimando, thanks for your PR! This file within the Overview Guides is a copy of the mobile_api.xml within the RPC Spec Repo. If you'd like to suggest a change to this param description, please submit an issue/PR in the RPC Spec Repo: https://github.com/smartdevicelink/rpc_spec. This will help to ensure the description is consistent across all projects that include any reference to the mobile_api.xml/RPC Spec. Thank you!
Author
|
Ok Made PR #284 for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A current problem we're having is that there's no consistent documentation with preset 0. Should it be first in the preset list or last? This matters if you're setting custom preset names, since the app just sends an array of strings to name the presets. So if preset 0 is in the wrong spot, it throws off all the preset names. Currently Pandora considers it as preset 10 vs iHeartRadio considers it as preset 0.
This came up because we've never had a sync that can use 10 presets AND show the preset label.
sync3 only does presets 1-8 and shows labels.
sync1 does 10 presets but no labels