Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Oct 15, 2025

Fixes #453

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts the x509 certificate updater from a Kubernetes Deployment to a CronJob that runs every 6 hours. The change addresses issue #453 by implementing a more appropriate scheduling mechanism for periodic certificate updates.

  • Added a --loop argument to control whether the updater runs continuously or exits after one execution
  • Modified the Python script to exit after the first pass when not in loop mode
  • Changed the Kubernetes resource from Deployment to CronJob with a 6-hour schedule

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
x509_secrets/x509_updater.py Added loop argument and conditional exit logic for single-run execution
helm/servicex/templates/x509-secrets/deployment.yaml Converted from Deployment to CronJob with 6-hour schedule

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me - though I think Ben should probably approve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

X509 Secrets should be made into a cronjob and not a deployment

2 participants