-
-
Couldn't load subscription status.
- Fork 23
Update coverage configuration #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1191 +/- ##
===========================================
- Coverage 92.72% 85.42% -7.30%
===========================================
Files 80 93 +13
Lines 2309 3163 +854
Branches 154 355 +201
===========================================
+ Hits 2141 2702 +561
- Misses 143 387 +244
- Partials 25 74 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables code coverage reporting to codecov.io by adding .coveragerc configuration files across multiple services and updating the CI workflow to generate and upload coverage reports.
- Adds standardized
.coveragercfiles to all service directories to configure coverage collection - Updates CI workflow to generate XML coverage reports and upload them to codecov
- Enables test requirement for
did_finder_rucioservice
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| transformer_sidecar/.coveragerc | Adds coverage configuration for transformer_sidecar with source tracking and exclusion rules |
| servicex_app/.coveragerc | Adds coverage configuration for servicex_app with source tracking and exclusion rules |
| did_finder_xrootd/.coveragerc | Adds coverage configuration for did_finder_xrootd with source tracking and exclusion rules |
| did_finder_rucio/.coveragerc | Updates existing coverage configuration to add report settings and exclusion rules |
| did_finder_cernopendata/.coveragerc | Adds coverage configuration for did_finder_cernopendata with source tracking and exclusion rules |
| code_generator_raw_uproot/.coveragerc | Adds coverage configuration for code_generator_raw_uproot with source tracking and exclusion rules |
| code_generator_python/.coveragerc | Adds coverage configuration for code_generator_python with source tracking and exclusion rules |
| code_generator_funcadl_xAOD/.coveragerc | Updates source path from servicex to xaod_code_generator/ |
| code_generator_funcadl_uproot/.coveragerc | Adds coverage configuration for code_generator_funcadl_uproot with source tracking and exclusion rules |
| code_generator_TopCPToolkit/.coveragerc | Adds coverage configuration for code_generator_TopCPToolkit with source tracking and exclusion rules |
| .github/workflows/deploy-config.json | Enables test requirement for did_finder_rucio |
| .github/workflows/ci_servicex.yaml | Adds coverage XML generation and codecov upload with explicit file specification |
Comments suppressed due to low confidence (4)
did_finder_xrootd/.coveragerc:1
- Corrected syntax: 'main' should not have periods around it. The correct pattern is
if __name__ == \"__main__\":
did_finder_rucio/.coveragerc:1 - Corrected syntax: 'main' should not have periods around it. The correct pattern is
if __name__ == \"__main__\":
did_finder_cernopendata/.coveragerc:1 - Corrected syntax: 'main' should not have periods around it. The correct pattern is
if __name__ == \"__main__\":
code_generator_TopCPToolkit/.coveragerc:1 - Corrected syntax: 'main' should not have periods around it. The correct pattern is
if __name__ == \"__main__\":
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
For some reason the |
Enable uploading of coverage data to codecov.io