Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Nov 1, 2025

Update cernopendata-client version

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.69%. Comparing base (e68e6a4) to head (60c2640).

❗ There is a different number of reports uploaded between BASE (e68e6a4) and HEAD (60c2640). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (e68e6a4) HEAD (60c2640)
44 33
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1198      +/-   ##
===========================================
- Coverage    85.83%   76.69%   -9.14%     
===========================================
  Files           94       29      -65     
  Lines         3191      957    -2234     
  Branches       359      133     -226     
===========================================
- Hits          2739      734    -2005     
+ Misses         378      182     -196     
+ Partials        74       41      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ponyisi
Copy link
Collaborator Author

ponyisi commented Nov 1, 2025

Hopefully addresses #1156

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the CERN OpenData client integration to use a specific protocol (xrootd) and migrates from a specialized Docker base image to a standard Python image with cernopendata-client as a dependency.

  • Adds --protocol xrootd flag to the cernopendata-client command to explicitly specify the file access protocol
  • Migrates from cernopendata/cernopendata-client:0.3.0 Docker base image to python:3.10 with cernopendata-client as a Poetry dependency
  • Removes workaround for certifi uninstall issue that was specific to the old base image

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
did_finder_cernopendata/src/did_finder_cernopendata/celery.py Adds --protocol xrootd flag to cernopendata-client command invocation
did_finder_cernopendata/pyproject.toml Adds cernopendata-client 1.0.0 as an explicit dependency
did_finder_cernopendata/poetry.lock Updates lock file with cernopendata-client package and dependencies
did_finder_cernopendata/Dockerfile Changes base image from cernopendata/cernopendata-client to python:3.10 and comments out certifi workaround

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator Author

@ponyisi ponyisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses #975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants