-
-
Notifications
You must be signed in to change notification settings - Fork 23
Update cernopendata-client to 1.0.0 #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #1198 +/- ##
===========================================
- Coverage 85.83% 76.69% -9.14%
===========================================
Files 94 29 -65
Lines 3191 957 -2234
Branches 359 133 -226
===========================================
- Hits 2739 734 -2005
+ Misses 378 182 -196
+ Partials 74 41 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
Hopefully addresses #1156 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the CERN OpenData client integration to use a specific protocol (xrootd) and migrates from a specialized Docker base image to a standard Python image with cernopendata-client as a dependency.
- Adds
--protocol xrootdflag to the cernopendata-client command to explicitly specify the file access protocol - Migrates from
cernopendata/cernopendata-client:0.3.0Docker base image topython:3.10with cernopendata-client as a Poetry dependency - Removes workaround for certifi uninstall issue that was specific to the old base image
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| did_finder_cernopendata/src/did_finder_cernopendata/celery.py | Adds --protocol xrootd flag to cernopendata-client command invocation |
| did_finder_cernopendata/pyproject.toml | Adds cernopendata-client 1.0.0 as an explicit dependency |
| did_finder_cernopendata/poetry.lock | Updates lock file with cernopendata-client package and dependencies |
| did_finder_cernopendata/Dockerfile | Changes base image from cernopendata/cernopendata-client to python:3.10 and comments out certifi workaround |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses #975
Update cernopendata-client version