Skip to content

Conversation

@AndrewEckart
Copy link
Contributor

@AndrewEckart AndrewEckart marked this pull request as draft November 16, 2020 16:26
@AndrewEckart
Copy link
Contributor Author

Re: the chart, this would be a good opportunity to reorganize the values a little bit, into something more like:

app:
  auth:
    enabled: true
    disableUserMgmt: false (default)
    globusClientID: *****
    globusClientSecret: *****

I think that the mailgunApiKey, mailgunDomain, and slackSigningSecret should be kept at the app level since those could conceivably be used for other things. I'm not sure about the newSignupWebhook, though, since that only applies when auth and user management are enabled.

@AndrewEckart AndrewEckart force-pushed the disable-user-mgmt branch 2 times, most recently from 27a3c36 to d2e802b Compare November 17, 2020 13:21
@BenGalewsky BenGalewsky closed this Oct 1, 2022
@ponyisi ponyisi deleted the disable-user-mgmt branch August 4, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants