-
-
Notifications
You must be signed in to change notification settings - Fork 10
chore: Update used ListenerClasses according to decision #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (tested enough stacks to cover all product changes) - just the one trino.yaml where the listener class is still under clusterConfig.
matchLabels: | ||
trino: trino | ||
listenerClass: external-unstable | ||
listenerClass: external-stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still under clusterConfig. Also (not part of this PR), I get the error:
failed to parse TrinoCatalog.v1alpha1.trino.stackable.tech/hives3.default: trino 469 and greater require TLS for S3
trino: trino | ||
listenerClass: external-unstable | ||
listenerClass: external-stable | ||
coordinators: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coordinators: | |
coordinators: | |
roleConfig: | |
listenerClass: external-stable |
matchLabels: | ||
trino: trino | ||
listenerClass: external-unstable | ||
listenerClass: external-stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listenerClass: external-stable |
Part of stackabletech/issues#770
According to decision https://github.com/stackabletech/decisions/issues/7
Also got rid of the unmaintained
keycloak-opa-poc
stack