Skip to content

Conversation

sbernauer
Copy link
Member

Part of stackabletech/issues#770
According to decision https://github.com/stackabletech/decisions/issues/7

Also got rid of the unmaintained keycloak-opa-poc stack

@sbernauer sbernauer self-assigned this Oct 7, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Oct 7, 2025
@adwk67 adwk67 self-requested a review October 10, 2025 10:16
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 10, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (tested enough stacks to cover all product changes) - just the one trino.yaml where the listener class is still under clusterConfig.

matchLabels:
trino: trino
listenerClass: external-unstable
listenerClass: external-stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still under clusterConfig. Also (not part of this PR), I get the error:

failed to parse TrinoCatalog.v1alpha1.trino.stackable.tech/hives3.default: trino 469 and greater require TLS for S3

trino: trino
listenerClass: external-unstable
listenerClass: external-stable
coordinators:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
coordinators:
coordinators:
roleConfig:
listenerClass: external-stable

matchLabels:
trino: trino
listenerClass: external-unstable
listenerClass: external-stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
listenerClass: external-stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants