Skip to content

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented Sep 3, 2025

Summary

  • Add UI reachability check to verify Central UI is accessible from internet before marking routes as created
  • Implement mockable UIReachabilityChecker interface for testability
  • Check reachability after CNAME records are in sync (INSYNC status)
  • Support both fleet-manager managed CNAME records and external-dns managed scenarios

Changes

  • Added UIReachabilityChecker interface with HTTP-based implementation
  • Integrated reachability check in CentralRoutesCNAMEManager.Reconcile() method
  • Added comprehensive test coverage with mock implementations
  • Only mark routes as created when UI is actually reachable from internet

Testing

  • Added unit tests covering various scenarios:
    • UI reachable after CNAME sync
    • UI not reachable after CNAME sync
    • Reachability check failures
    • External DNS managed scenarios
    • Empty UI host handling

Related

- Add UIReachabilityChecker interface for checking if Central UI is reachable
- Implement HTTP-based reachability checker with HEAD requests
- Integrate reachability check after CNAME records are in sync
- Support both fleet-manager managed and external-dns managed scenarios
- Add comprehensive test coverage with mock implementations
- Only mark routes as created when UI is actually reachable from internet
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 3, 2025
@ludydoo
Copy link
Collaborator Author

ludydoo commented Sep 3, 2025

/retest

Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

@ludydoo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e f2f7ae0 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant