-
Notifications
You must be signed in to change notification settings - Fork 0
ROX-31474: Add MCP server stack #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mtodor/ROX-31474-add-config
Are you sure you want to change the base?
ROX-31474: Add MCP server stack #4
Conversation
80a7f51 to
1ace0ae
Compare
| BINARY_NAME=stackrox-mcp | ||
|
|
||
| # Version (can be overridden with VERSION=x.y.z make build) | ||
| VERSION?=0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe when not provided we should use git describe --tags --abbrev=10 --dirty --long instead? So development builds will have commit information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janisz This does not work for me:
❯ git describe --tags --abbrev=10 --dirty --long
fatal: No names found, cannot describe anything
For local dev, we could use: git rev-parse --short HEAD - but on tag builds, we could get tag info from CI environment. Any better ideas?
35e724b to
c267e67
Compare
19a0352 to
489ceb5
Compare
c267e67 to
af7929f
Compare
489ceb5 to
b710ab2
Compare
af7929f to
ea3282b
Compare
b710ab2 to
1acf52b
Compare
ea3282b to
baf9de0
Compare
1acf52b to
5650c9e
Compare
This PR is adding the following:
Additional tweaks:
NOTE: We are using tools mocks for testing. In this PR I will leave it as it is. But I will create a follow-up PR where I will replace mocks with one's generated by mocking framework.