ROX-31475: Add StackRox client #5
Open
+2,360
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtodor
force-pushed
the
mtodor/ROX-31477-add-stackrox-client
branch
5 times, most recently
from
df41746 to
79b040c
Compare
mtodor
force-pushed
the
mtodor/ROX-31477-add-stackrox-client
branch
from
79b040c to
0f4dbd3
Compare
mtodor
changed the title
janisz
reviewed
Nov 21, 2025
| allToolsets := getToolsets(&config.Config{}, &client.Client{}) | ||
|
|
||
| allToolsets := getToolsets(cfg) | ||
| toolsetNames := make(map[string]bool) |
There was a problem hiding this comment.
nit: this boolean has no meaning we are only interested in keys
Suggested change
| toolsetNames := make(map[string]bool) | |
| toolsetNames := make(map[string]struct{}) |
since we have a dependency on stackrox we could use stringset
or since it's just a test a slice will be enough
janisz
reviewed
Nov 21, 2025
|
|
||
| require.NoError(t, err, "Should be able to establish HTTP connection to server") | ||
|
|
||
| _ = resp.Body.Close() |
There was a problem hiding this comment.
Suggested change
| _ = resp.Body.Close() | |
| require.NoError(t, resp.Body.Close()) |
janisz
reviewed
Nov 21, 2025
| c.mu.Lock() | ||
| defer c.mu.Unlock() | ||
|
|
||
| if !c.shouldRedialLocked() { |
There was a problem hiding this comment.
It's a personal preference but I think NoLock is more common:
https://github.com/search?q=repo%3Astackrox%2Fstackrox+Locked%28&type=code
https://github.com/search?q=repo%3Astackrox%2Fstackrox+NoLock%28&type=code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is adding StackRox Client.
It's adding the following functionalities:
insecureoption is renamed toinsecure_skip_tls_verifyto be more understandable and similar to other toolsFile:
internal/toolsets/config/tools.go- Besides that it also adds an example implementation oflist_clusterstool. Purpose of that is to simply test the full flow. Proper implementation oflist_clusterstool will be done in a followup PR.