-
Notifications
You must be signed in to change notification settings - Fork 8
Enable quota-based instant delegation with era restrictions #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
e61c7ee
395ce30
b0cce19
ec34754
b57e74e
a6c9f26
56c7665
58ceff3
bcd2d3d
a20f8e3
ef19c05
7fb4c2f
cbd71ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,15 @@ | ||
| changesetBaseRefs: | ||
| - main | ||
| - origin/main | ||
| - main | ||
| - origin/main | ||
|
|
||
| enableImmutableInstalls: false | ||
|
|
||
| enableProgressBars: false | ||
|
|
||
| nodeLinker: node-modules | ||
|
|
||
| npmAuthToken: '${NPM_TOKEN:-}' | ||
| npmAuthToken: "${NPM_TOKEN:-}" | ||
|
|
||
| npmPublishRegistry: 'https://registry.npmjs.org' | ||
| npmPublishRegistry: "https://registry.npmjs.org" | ||
|
|
||
| plugins: | ||
| - path: .yarn/plugins/@yarnpkg/plugin-typescript.cjs | ||
| spec: '@yarnpkg/plugin-typescript' | ||
| - path: .yarn/plugins/@yarnpkg/plugin-version.cjs | ||
| spec: '@yarnpkg/plugin-version' | ||
| - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs | ||
| spec: '@yarnpkg/plugin-interactive-tools' | ||
|
|
||
| yarnPath: .yarn/releases/yarn-3.6.4.cjs | ||
| yarnPath: .yarn/releases/yarn-4.10.3.cjs |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import * as dotenv from 'dotenv'; | ||
| import '@nomiclabs/hardhat-etherscan'; | ||
| import '@nomicfoundation/hardhat-verify'; | ||
| import '@nomiclabs/hardhat-waffle'; | ||
| import '@typechain/hardhat'; | ||
| import 'hardhat-contract-sizer'; | ||
|
|
@@ -453,33 +453,7 @@ const config: HardhatUserConfig = { | |
| gasPrice: 21, | ||
| }, | ||
| etherscan: { | ||
| apiKey: { | ||
| polygonMumbai: process.env.POLYGONSCAN_API_KEY, | ||
| goerli: process.env.ETHERSCAN_API_KEY, | ||
| sepolia: process.env.ETHERSCAN_API_KEY, | ||
| base: process.env.BASESCAN_API_KEY, | ||
| 'base-sepolia': process.env.BASESCAN_API_KEY, | ||
| polygon: process.env.POLYGONSCAN_API_KEY, | ||
| mainnet: process.env.ETHERSCAN_API_KEY, | ||
| }, | ||
| customChains: [ | ||
| { | ||
| network: 'base-sepolia', | ||
| chainId: 84532, | ||
| urls: { | ||
| apiURL: 'https://api-sepolia.basescan.org/api', | ||
| browserURL: 'https://sepolia.basescan.org', | ||
| }, | ||
| }, | ||
| { | ||
| network: 'base', | ||
| chainId: 8453, | ||
| urls: { | ||
| apiURL: 'https://api.basescan.org/api', | ||
| browserURL: 'https://basescan.org', | ||
| }, | ||
| }, | ||
| ], | ||
| apiKey: process.env.ETHERSCAN_API_KEY, | ||
| }, | ||
|
Comment on lines
455
to
457
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainVerify multi-network verification still works. The etherscan configuration has been simplified from a multi-network The scripts at lines 26-27 reference scan-verify tasks for testnet (base-sepolia) and mainnet (base) networks. Ensure these verification tasks still function correctly without the custom chain definitions. 🌐 Web query: 💡 Result: Short answer: No — not always. The plugin doesn't always force a customChains entry, but Base Sepolia frequently needs one unless your installed hardhat-verify version already includes Basescan as a built-in explorer. Check what networks your installed plugin knows with: npx hardhat verify --list-networks If "base" / "base-sepolia" (or the exact network key you use) is not listed, add a customChains entry for Base / Base Sepolia in your etherscan config (examples and Base docs show adding customChains for base-sepolia). [1][2][3] Sources:
I need to verify the repository's setup to determine if the removal of 🏁 Script executed: #!/bin/bash
# Check installed version of hardhat-verify and current hardhat.config.ts state
echo "=== Checking package.json for hardhat-verify version ==="
jq '.devDependencies["@nomicfoundation/hardhat-verify"]' package.json 2>/dev/null || rg '@nomicfoundation/hardhat-verify' package.json -A1 -B1
echo ""
echo "=== Current etherscan config in hardhat.config.ts (lines 450-480) ==="
sed -n '450,480p' hardhat.config.ts
echo ""
echo "=== Checking for customChains in hardhat.config.ts ==="
rg -n 'customChains' hardhat.config.ts -C3 || echo "No customChains found"
echo ""
echo "=== Lines 20-40 to see scan-verify task references ==="
sed -n '20,40p' hardhat.config.tsLength of output: 1773 I need to locate the scan-verify tasks referenced and search for more specific information about Base network support in v2.1.3. 🏁 Script executed: #!/bin/bash
# Find scan-verify or verify task definitions
echo "=== Searching for scan-verify or verify tasks ==="
rg -n 'scan-verify|verify.*task' hardhat.config.ts -C5
echo ""
echo "=== Searching for any reference to base networks ==="
rg -n -i 'base.*sepolia|base-sepolia|base' hardhat.config.ts -C2
echo ""
echo "=== Checking git log to see what was changed ==="
git log --oneline -20 hardhat.config.ts 2>/dev/null || echo "Git history not available"
echo ""
echo "=== Checking git diff for recent changes to etherscan config ==="
git diff HEAD~5..HEAD hardhat.config.ts 2>/dev/null | grep -A10 -B10 'etherscan\|customChains' || echo "Git diff not available"Length of output: 2751 I need to search for specific information about Base and Base Sepolia support in @nomicfoundation/hardhat-verify v2.1.3, and whether the single apiKey string is compatible with multi-network verification. 🌐 Web query: 💡 Result: Short answer: No — @nomicfoundation/hardhat-verify v2.1.3 does not include built‑in support for Base Sepolia (chainId 84532). Use a customChains entry (or map the explorer to a supported provider) to verify on Base Sepolia. [1][2] Sources:
References: I need to verify if Base mainnet has built-in support in v2.1.3, and clarify the apiKey configuration approach. 🌐 Web query: 💡 Result: Yes — Base mainnet uses chainId 8453, and @nomicfoundation/hardhat-verify supports Blockscout-compatible explorers (so you can verify on Base’s Blockscout/Etherscan-style explorers). Sources: Hardhat Verify docs and Base docs. [1][2][3] Minimal example (hardhat.config.js / ts) — verify using Blockscout for Base mainnet (chainId 8453):
Example (JS): Verify command examples:
References:
Would you like a ready-to-use hardhat.config.js snippet with an example verify command including an actual Blockscout API URL? Multiple critical issues introduced by this configuration change. The removal of
Fix required: Either restore the 🤖 Prompt for AI Agents |
||
| typechain: { | ||
| outDir: 'src/typechain', | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.